Florian Lehner

Results 176 comments of Florian Lehner

I'm not a k8s expert, so I'm not advising and just report my own experience. When I did set up [kind](https://kind.sigs.k8s.io/), I think it did the trick around cgroup v2...

> [..] I've observed significant spikes in both CPU usage As the eBPF profiler also profiles itself, can you share the flamegraph or stacktraces of the moments, when you encounter...

Hi @EmilRte Can you please check with Pyroscope which field/timestamp they are using and in which format (nano second or something else) that results in this error?

> Does it make sense for the OTel collector to serve as an adapter [..] https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/42843 is the first step in that direction with converting pprof to OTel profiles. Further...

Closing this issue, as in https://github.com/open-telemetry/opentelemetry-ebpf-profiler/issues/997 user reported the same problem with timestamps and confirmed that an update of the backend resolved the issue.

@jade-guiton-dd with https://github.com/open-telemetry/opentelemetry-collector/pull/14235/commits/92bc761e5e9414dbe2c7ea931cd7a09a1c409f75 I have started to deduplicate code. But the win of deduplication is limited. While it seems that a good portion of code is duplicate, they differ in...

Good catch with the `controller` - I moved it with https://github.com/open-telemetry/opentelemetry-collector/pull/14235/commits/71b753d9b3ae3d9b08dfa9c1b303dab31004a06f.

@jade-guiton-dd I'm about to revert https://github.com/open-telemetry/opentelemetry-collector/pull/14235/commits/71b753d9b3ae3d9b08dfa9c1b303dab31004a06f - the move of parts of controller into a dedicated shared package. The reason is, that this is a major breaking change for all...

@jade-guiton-dd with using scraperhelper in xscraperhelper I was able to remove the duplicate code around ControllerConfig. For `type controller[T component.Component] struct{}` and its methods I wasn't able to do so....

> The solution here would be to move ControllerConfig to an internal package a This option will not work, as `ControllerConfig` is an argument to the API of `scraperhelper`. If...