Francesco Lodolo
Francesco Lodolo
Can't test this locally at the moment, but adding a few notes: * I simplified the creation of `BLOCKED_IP_RANGES` in `base.py`. Technically, you could do it with a set of...
On second thoughts, I'm going to move the logic to `base.py` in a separate commit, in case it's easy to back out. My assumption is that the code in base.py...
No, this is about visitors (i.e. unauthenticated users), and matching their preferences. If the preference is not set, then we would use the default (dark).
> I think the behavior should be the same for unauthenticated users and new users. If you choose a light theme in your system settings and we honor that in...
I feel like there's a disconnect somewhere. * Unauthenticated users: follow user preferences (change from current behavior, where dark is default). * New users: dark theme. I read [your comment](https://github.com/mozilla/pontoon/issues/3339#issuecomment-2352753855)...
> Changing the default for unauthenticated users OTOH impacts all users (when they aren't logged in). It changes the current behavior for users who have not set their browser or...
Looks good, didn't look at the functionality itself though.
> As a precursor to migrating the public-facing API endpoints from GraphQL to DRF, we also need to remove GraphQL from the codebase. This doesn't sound right: we need to...
Should we block bots via robots.txt?