Frank Lichtenheld

Results 96 comments of Frank Lichtenheld

Since some of the links are just wrong I plan to submit this patch to the mailing list as part of an initiative to clean up the Github PR submissions.

> @flichtenheld was this sent to the ml? or not yet? https://patchwork.openvpn.net/project/openvpn2/patch/[email protected]/

I think I have fixed this with #921

Note that the issues pointed out by Codacy are not applicable since the same issue is present in all classes of Bitbucket Cloud modules.

> @flichtenheld does it actual ? Sorry, I don't understand. What is the question?

Note: I provided a fix for Bitbucket Cloud in PR #925 but it looks like Bitbucket Server will need a separate solution since the error format differs.

Another change I made was to add these new options to `BitbucketBase._new_session_args`. At least my assumption was that if you set backoff_and_retry=True when creating the `Cloud` object you would expect...

Actually functionality looks good to me. I have a Jenkins job running into the rate limiting, and this patch together with my modifications seems to solve the problem.

> > Another change I made was to add these new options to `BitbucketBase._new_session_args`. At least my assumption was that if you set backoff_and_retry=True when creating the `Cloud` object you...