Frank Lichtenheld

Results 96 comments of Frank Lichtenheld

Merged via 06c7ce5d1fc3b17e0da731d22002e58b9e2d4994

The important line is probably: `NOTE: Pulled options changed on restart, will need to close and reopen TUN/TAP device.` So it tried to preserve the TUN but it could not....

Normally we add new distros on the next bugfix release. But not sure when 2.6.11 will be released. I will bring it up in the Community meeting.

2.6.10 packages for Ubuntu 24.04 (noble) have been published to the usual place. See also https://github.com/OpenVPN/openvpn-build/pull/657

So if `init_tun()` is called with `strict_warn == true` then we warn when the second argument doesn't look like a netmask.

But the problem with that check is that it actually uses topology to detect whether we're in P2P mode: ``` bool is_tun_p2p(const struct tuntap *tt) { bool tun = false;...

Nevermind, in current master we do not actually use `is_tun_p2p`. This is only added by my patch https://gerrit.openvpn.net/c/openvpn/+/380. Master uses `tt->type == DEV_TYPE_TUN` which is just not correct, so the...

Changing the default only for `--server` would probably look something like this: * Change default to `TOP_UNDEF` instead of `TOP_SUBNET` * In `helper_client_server` check whether topology is still `TOP_UNDEF`, if...

As discussed on IRC: There is already a `TOP_P2P` which does something slightly different again, although most of the code treats it as alias for `TOP_NET30`.

> So the `topology` default has been taken care of, but the other aspect of passing on `-1` as netbits after parsing is still not really helpful error handling. @cron2...