Flávio J. Saraiva

That's probably not a good idea, since it would likely be a weird mix of styles. The lazyish approach: find an already defined naming style somewhere that looks good to...

Taking the lazyish approach, here is one that looks good to me: http://geosoft.no/development/cppstyle.html

I want a naming style, not formatting style. astyle and clang-format format space, they don't handle names. Not sure about clang-tidy but the rules seem to be about functional stuff,...

I think you should forget about an automated style checker for C/C++. Even if we find one, using it would require changing the old code before enabling it.

Since there are no other opinions about the naming in http://geosoft.no/development/cppstyle.html, for now I'll use it in the C-rust interface and skip documenting it as the "last resort" style for...

I learned a lot about locale stuff in https://github.com/ja2-stracciatella/ja2-stracciatella/pull/870. This function probably exists because of locale encoding issues. As an example: TEXT_CODE_BOLD and TEXT_CODE_CENTER, or ² and ³, are not...

Hmm, if the reason for the function existing is locale encoding issues then it isn't needed anymore... I think it's fine to remove it if unittests for locale isses are...

Quick-fix that does not place soldiers on top of vehicle corpses: [quickfix-133.txt](https://github.com/ja2-stracciatella/ja2-stracciatella/files/3466566/quickfix-133.txt) A proper fix should prevent the grid from being selected in the first place.

Well, a frame is indeed a single point in time, but it actually represents a span of time (determined by the frequency). I expect to get the same duration of...

Since there is silence after you play a sound, I would expect it to interpolate towards silence, but I don't really care about interpolated values. I'm satisfied as long as...