Flavien DELANGLE

Results 521 comments of Flavien DELANGLE

> Should we have support for selecting time also in calendar component ? It wouldn't be in the `Calendar` component. We could consider having a component for time editing, but...

@michaldudak could you give me a basic JSX example of what it could look like?

I have mixed feelings with the shortcuts on the DX here. Is the few lines of JSX removed worth the new concept that people will have to learn? That's always...

Another point, I decided to let the user map the cells, to be super flexible, but we could of course discuss replacing: ```tsx {({ days }) => days.map((day) => (...

> This seems more promising to me. I prefer it without the map. If we can't think of a valid use case we'd be restricting, it seems we should do...

> Drop "Day" and just call it Calendar.Grid? The naming was picked when the calendar supported month and year navigation. If you think we shouldn't support those views then clearly...

@atomiks React Aria writes "Next" as the aria label of the button that goes to the next month. To do something similar we would need a localization support inside our...

I'll add "Next" / "Previous" labels then :ok_hand:

By the way, I'll remove the year navigation button for now. There is a use case where people want to have a double right arrow to navigate year per year...

@colmtuite I split the `SetVisibleMonth` part: `SetMonth` `SetPreviousMonth` and `SetNextMonth` My main concern with this naming is that we loose the information that it only navigate through the months but...