Flavien DELANGLE
Flavien DELANGLE
Not a huge fan of the prop name. I saw quite a lot of `renderXXX` props that were render props (`renderItem={item => }`). So I wouldn't use the same type...
I don't have a very good proposal :/ `nestedDialogRenderMode` is very verbose
@copilot Please fix the CI
@copilot The CI is still red
@copilot please fix the CI, and re-run it before commiting...
@copilot please use an object instead of a Map to represent the visible resources (`props.visibleResources`, `props.defaultVisibleResources` but also `state.visibleResources` and all the selectors and usage of this state).
@noraleonte is having a look at the issue 👍
I'd be interested to have a reproduction case here before applying a fix. I agree that the failsafe proposed by @michelengelen make sense, but I would like to understand why...
> Applying the suggested fix ruins the UX of the data selection, hence, I'm not sure if this is the best solution. 🤔 Is this the fixed you just merged...
No problem keeping it simple for now :+1: