Joe Reuter

Results 130 comments of Joe Reuter

android:descendantFocusability="blocksDescendants" didn't work for me either - nexus 4, android 4.4

This is bloating the bundle size of the gauge plugin - it seems like the gauge plugin is importing the icons from the package, then re-exporting them for Lens. Let's...

@alexwizp seems like the expression gauge plugin is still exporting the icons from the main `index.ts` file and the page load bundle is still bloated:

It's still re-exporting the chart icons package on the plugin, this time it's indirect via https://github.com/elastic/kibana/pull/138413/files#diff-84830ea845fdd1ad14f04dcd087863b4b0983805bee885c3da03eb9e229d8b48R15 because `component/utils` is importing the icons for the `getIcons` helper. As the `getIcons` helper...

> Add support of palette expression function instead of string Lens should support palette expression function already: Add support of palette expression function instead of string > Check if filters...

I see, for Lens this wouldn't be relevant because we aren't manipulating filters this way (it's just the kibana context, then esaggs). I see it being relevant for Canvas.

Hey, thanks for your contribution! I opened a PR for `isDestroyed` thing already here: https://github.com/elastic/kibana/pull/138368 But the `disabled` setting makes sense to me

> I wonder why don't we allow the transition for multiple layers Vlad and me discussed this - as the chart looks pretty weird due to the empty slots for...

Looks pretty good, just found one bug: "Last value" mode is not respected for formula-type dimensions (like standard deviation or filter ratio) - it seems like it's just ignored for...

Seems like filter ratio is not convertable anymore: Maybe the check for "missing field" went wrong? It also still tries to set the reduced time range when on a timeseries...