Nikita Shilnikov

Results 163 comments of Nikita Shilnikov

https://github.com/rom-rb/rom/issues/491 tl;dr mutation is bad, mkay?

I still think having a convention for reserved words like `do |then|` -> `do |then_|` would be good enough

This is what I use in these cases ```ruby # user_repo.rb require 'dry/effects' class UserRepo < ROM::Repository[:users] include ::Dry::Effects.Reader(:page_size, default: 20) def list(page: 1) users.per_page(page_size).page(page).to_a end end # user_repo_spec.rb require...

Hm, it's not a bug, every piece of code relying on `Thread.current` will need some sort of interoperability with dry-effects. I'll take a look at these libraries for more information.

Yeah, absolutely. It works "as expected" because ruby works this way. Fortunately, all thread local usages can be replaced by the state effect. It should be mentioned in the docs...

I considered this. The plan was to add a compatibility layer to the gem via extensions. For example, there's one [for rspec](https://github.com/dry-rb/dry-effects/blob/4574480d2636d93d554f00c4bf2b110ae7f05d35/lib/dry/effects/extensions/rspec.rb). Making it work in general is though possible...

Definitely something to improve :) ![chewy](https://user-images.githubusercontent.com/802486/117262400-e27b8400-ae59-11eb-9413-b905d7a757c3.png)

I'm not sure if this is "fixable". It's certainly [possible](https://github.com/dry-rb/dry-effects/blob/master/spec/integration/interrupt_spec.rb) to emulate `catch`/`throw` with effects and then patch libraries to account for this. The problem here is effects are not...

@robhanlon22 I haven't looked in details yet, but I'm positive overall. I'll get back to this probably next week (traveling atm). Thanks for working on this ❤️