dry-effects icon indicating copy to clipboard operation
dry-effects copied to clipboard

Messy data in profilers (New Relic, etc.)

Open vladislav-yashin opened this issue 3 years ago • 1 comments

Describe the bug

Code wrapped by effect handler is not analyzed by profilers (such as New Relic and Skylight) properly (e.g. no sql queries data when wrapped in rails controller and complete mess when wrapped with middleware)

To Reproduce

Wrap code by effect handler and introduce some profiler in the app.

Expected behavior

Code is profiled as usual.

Your environment

  • Affects my production application: YES
  • Ruby version: 2.7.1
  • OS: .Ubuntu 20.04

I'm not sure whether it's new relic/skylight problem or dry's, but hope to get some hint at least.

vladislav-yashin avatar Aug 27 '20 19:08 vladislav-yashin

Hm, it's not a bug, every piece of code relying on Thread.current will need some sort of interoperability with dry-effects. I'll take a look at these libraries for more information.

flash-gordon avatar Aug 28 '20 03:08 flash-gordon