Fadi Khadra comments

Results 125 comments of


                                            Fadi Khadra

Component could prevent updates propagating through render prop

Hey @tapayne88, Thanks for the information. I'll read the article tonight. I also want to check if the intersection observer api is a good alternative.

Include CHANGELOG or add release notes?

Hey, Thank you for your feedback. I totally agree with you. Starting next year, I'll generate changelogs based on commit. If you are upgrading from v1 to v2 you should...

Switch to intersection observer api when compatible with most browser

Thanks @Freddy03h I'll take a look at it.

react native support

Hello @rlaurente, It's working on mobile. For react-native I need to test. But I could try to support it.

Adding a prop that can contain a callback function that will receive isVisible

Hello @blaineo, Sorry for the late reply. Since the end of december I'm preparing my move so I'm quite busy. It will be done at the end of the month....

contextMenu.show doesn't work with onMouseUp Event

Hey, Unfortunately, I don't have a windows machine to troubleshoot this issue.

How to close contex menu when scrolling

Hey @NemanjaS2P, this is already the default behavior. https://user-images.githubusercontent.com/5574267/102987372-7c2d3f00-4512-11eb-8189-a19f7db10b9a.mov If it's not your case, could you share the code in a code sanbox ? Thanks

Modify positioning formula

Hey @jingwuluo , Can you describe what your PR bring? I'm failing to understand. Thanks a lot

Props not passed when Items inside intermediary component

Hey @sbrichardson, thanks a lot for sharing those details. I'll work on a fix

Notification content not showing in toast

@znat looks like you didn't import the required CSS ```js import { ToastContainer, toast } from 'react-toastify'; import 'react-toastify/dist/ReactToastify.css'; ```