react-on-screen icon indicating copy to clipboard operation
react-on-screen copied to clipboard

Component could prevent updates propagating through render prop

Open tapayne88 opened this issue 7 years ago • 1 comments

Frustratingly, after reading this blog post https://cdb.reacttraining.com/react-inline-functions-and-performance-bdff784f5578 it looks like the shouldComponentUpdate optimisation I included in #21 will prevent prop changes propagating through to components within the render prop :(

tapayne88 avatar Apr 05 '18 12:04 tapayne88

Hey @tapayne88,

Thanks for the information. I'll read the article tonight. I also want to check if the intersection observer api is a good alternative.

fkhadra avatar Apr 05 '18 13:04 fkhadra