Fadi Khadra

Results 125 comments of Fadi Khadra

@thib3113 I want to 😭. The module system in our ecosystem is so messy. If I revert the PR then I would break vitejs and nextjs. I don't see any...

I've also found this solution, for those who cannot migrate to v5 https://github.com/reactioncommerce/reaction-component-library/issues/399#issuecomment-467860022

@thib3113 regarding semver, this is debatable. There are no breaking changes introduced in the library itself. **The main issue is that CRA v4 does not support es module.** But as...

Hey @Robloche, I understand your concern but supporting something that's 2 years old + modern bundlers is a lot of work. Can't you upgrade CRA? As a maintainer, we are...

Hey, @raccoonback sorry kind of busy ATM, hence the delay. Only safari is impacted? Or does the same happen with other browsers as well?

Hey so I've tested with the latest safari release`Version 15.4 (17613.1.17.1.6)` and it seems that the issue is now gone. https://user-images.githubusercontent.com/5574267/158372630-e1665e4e-1f18-482b-8d65-86a0ff0e6d6e.mov

Ok, I'll try the way you described it. ``` Regardless of the Safari version, I think the issue should be resolved. 😃 ``` Agree with you, but given the kind...

Hey @raccoonback, I was busy with the v9 + upgrade to react18, https://github.com/fkhadra/react-toastify/pull/731. Your PR is ok but I want to check if this can be an addon(new in v9...

Hey @raccoonback, sorry for the late reply. I've tested your PR and it breaks the current behavior when the user releases the notification With your change, we can see that...

Hey, This is not implemented. I could add that to the v6 roadmap