Fernando Jorge Mota
Fernando Jorge Mota
I just rebased this branch over the changes on the `feature/new-onboarding-wizard`, and I fixed the conflict in that merge. I decided to rebase instead of merge because I assume no...
I added @merkushin and @m1r0 as reviewers so they can check if this change looks okay, too (given they worked on refactoring that code a few weeks ago). :)
@jom @aaronfc I think it's better to create a separate ticket to handle that, right? :)
@jom Do you have any ways to reproduce the issue properly? Maybe we could try to find a proper solution together. I particularly don't remember seeing that issue before...
Just for closing the loop, I sent PRs #5947 and 1819-gh-Automattic/sensei-pro to fix this issue using `resolve-url-loader`. :)
I'm merging this even though the @renatho's review was dismissed because I just merged the feature branch back into this branch. Github was warning about a few conflicts, but...locally, those...
Hey @renatho, thanks for your review and sorry for the late answer. Just replying your question: > I checked that notices seem to be working correctly on other pages outside...
@dadish Hey there, thanks for the ping. Now I don't know exactly what to do.. :shrug: This PR is intended to fix the issue with the notices showing on the...
@dadish Ok, closing then. @yscik I thought about adding to `the_content`, but I wasn't sure if that filter runs on every page that needs notices, so that's why I didn't...
I'm closing this issue as not planned, then. Thanks for the check!