sensei icon indicating copy to clipboard operation
sensei copied to clipboard

Fix issue with enrolling students in the course view in a course with no students

Open fjorgemota opened this issue 2 years ago • 5 comments

Fixes #5504

Changes proposed in this Pull Request

  • Move $sensei_list_table->display(); out of the <form> tag used for the filters, allowing the forms inside the table (and after the table) to work correctly;

Testing instructions

Follow the instructions on issue #5504 and make sure that the user is enrolled and no notices are shown.

Also, verify if the layout/design is exactly the same as before.

fjorgemota avatar Sep 05 '22 18:09 fjorgemota

Codecov Report

Merging #5583 (2b44a39) into trunk (7a8ac40) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #5583   +/-   ##
=========================================
  Coverage     44.45%   44.45%           
  Complexity     8799     8799           
=========================================
  Files           420      420           
  Lines         31403    31403           
  Branches        239      239           
=========================================
  Hits          13960    13960           
  Misses        17269    17269           
  Partials        174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 386a246...2b44a39. Read the comment docs.

codecov[bot] avatar Sep 05 '22 18:09 codecov[bot]

I added @merkushin and @m1r0 as reviewers so they can check if this change looks okay, too (given they worked on refactoring that code a few weeks ago). :)

fjorgemota avatar Sep 05 '22 18:09 fjorgemota

@aaronfc Yeah, I think that's expected. We probably should only include published courses on the Choose Course modal.

jom avatar Sep 23 '22 17:09 jom

@jom @aaronfc I think it's better to create a separate ticket to handle that, right? :)

fjorgemota avatar Sep 28 '22 00:09 fjorgemota

@fjorgemota Yes, new issue.

jom avatar Sep 28 '22 12:09 jom

Merging on behalf of @fjorgemota, hope it is ok!

aaronfc avatar Nov 08 '22 09:11 aaronfc

I created the issue https://github.com/Automattic/sensei/issues/6097 to handle the issue related to draft courses, by the way.

fjorgemota avatar Nov 10 '22 18:11 fjorgemota