sensei icon indicating copy to clipboard operation
sensei copied to clipboard

Support animations for individual tasks completion.

Open aaronfc opened this issue 3 years ago • 3 comments

    Looks good to me!

I just added 2 questions for you.

I also think I read somewhere that we need an animation for every task the first time the user access the home after it's completed. If that's the case, I think we also need a similar thing for individual tasks (unless we decide to use local storage for that 🤔). This could be a separate issue. @Luchadores, could you confirm to us if this behavior I described is really the expected?

Originally posted by @renatho in https://github.com/Automattic/sensei/pull/5893#pullrequestreview-1136343828

aaronfc avatar Oct 11 '22 09:10 aaronfc

Hey @aaronfc 👋

The only animation I know of, that we worked on, is when the entire task list on Sensei Home has been completed. Here's the prototype for the one I'm talking about.

Luchadores avatar Oct 11 '22 10:10 Luchadores

Thanks @Luchadores !

@renatho ☝️ , can we remove this ticket then?

aaronfc avatar Oct 11 '22 10:10 aaronfc

Ah! Much easier! =) Yeah! I think we can remove this then! Sorry for the noise!

renatho avatar Oct 11 '22 14:10 renatho

I'm closing this issue as not planned, then. Thanks for the check!

fjorgemota avatar Oct 14 '22 00:10 fjorgemota