Fabian Jahr
Fabian Jahr
My impression from looking at the REST interface the last time was also that it's not standard in several ways. But it also seemed unclear who is actually using the...
Concept ACK, also reviewed the code and mostly satisfied. I think there is good potential for performance improvement here. I will wait with testing until the current comments are addressed.
Code looks good to me so far but I would like it more if the refactoring was in a separate commit and the commit message could go into more detail...
> One suggestion, if you could try it again, is to start `bitcoind` with the `-maxconnections=0`. I think each time you start `bitcoind` you can get a different set of...
ACK 5b1e92f539c24b6518f577b92874ccac0bbf617f I did a fresh re-review of the code. I currently don't have access to the machine [where I saw no speed-up before](https://github.com/bitcoin/bitcoin/pull/16981#issuecomment-614941536) but I ran another test on...
> I tried the syntax based on example mentioned in PR description and it gives me an error: > > ``` > $ bitcoin-cli scanblocks start '["addr(mzrj4QmPhk98vc2yQw42uCsgwfBjVzPPLM)"]' 1000000 > error...
I agree with @ch4ot1c that some users may not know that the app needs to be moved to `Applications/` but I think that could be solved with a clear instruction...
@hl222ih is right, I also just stumbled across that problem as well. 1.0.4 does what the readme says, 1.0.3 does not. You must have built 1.0.4 in coffee but then...
Any chance you add the body with it as well while you are at it? See https://github.com/travis-ci/travis-ci/issues/9302 Thanks!