fivepiece
fivepiece
The bip states that the reference implementation is https://github.com/jl2012/bitcoin/tree/bip114v2 , which does have : https://github.com/jl2012/bitcoin/blob/371928dbf2d924c7f55db882b7764209cd1e1543/src/script/interpreter.cpp#L463-L464 and https://github.com/jl2012/bitcoin/blob/371928dbf2d924c7f55db882b7764209cd1e1543/src/script/interpreter.cpp#L423-L424 Isn't it better to /add/ a note about these opcodes popping the value...
IMO it would be best to use a term like "witnessScript" for a couple of reasons - Segwit transactions can already contain a redeemScript part, eg p2sh-p2wsh, so "redeem script"...
Key : https://github.com/fivepiece (in bio) D351 76BE 9264 832E 4ACA 8986 BF07 92FB E95D C863 edit by chris belcher to add key: -----BEGIN PGP PUBLIC KEY BLOCK----- mQINBFpnnxcBEACbAg3YRxJQOHKbK4HeqzAcvNtukZDQmlcY7u53agrZjgY40La1 hrJc6GKkI028UBNeXOHH6y9CdVe9FhPAo7dfb2YzwsVHKSeGS8H/LCBH3R9UlrVK oqBXvfF2QfBInZ/M1m53tdoyTuBRA0r9dpMP5lSAL1Eiqj3654kejqwNbS1EsGqm...
Yep, seems to have fixed the crash using crash when using the flow described above : A tx is sent: ``` 19:55:46,807598 [ LOG] Found new tx: {'height': 0, 'fee':...
One interesting point brought up on irc is : ` a malicious miner can steal from everyone in the coinswap order book at the same time for the same cost`...
Understood. In that case I would feel a bit safer with a number closer to 6 than to 2 (wrt TX0\TX1 depth), 6 being the "recommended" acceptable depth for a...
I don't have a source, but guessing that it's very uncommon for anything larger than 1 block. Recently bitfury had a block orphaned, iirc. Would be interesting to look at...
I got the file from https://github.com/bitcoin/bitcoin/blob/master/depends/patches/qt/fix_qt_pkgconfig.patch The build continues. I'll open a new issue if anything else comes up, cheers.