bips
bips copied to clipboard
bitcoin
BIP 114: Add DROP after CLTV/CSV opcodes in flattened branches
In the HTLC example https://github.com/bitcoin/bips/blob/master/bip-0114.mediawiki#hashed-time-lock-contract I think there DROP is required after the CSV / CLTV opcodes
There was branch by the same author @jl2012 to make CSV/CLTV actually pop from the stack in MAST, but the behavior is not described or referred to in BIP114 at the moment.
The bip states that the reference implementation is https://github.com/jl2012/bitcoin/tree/bip114v2 , which does have :
https://github.com/jl2012/bitcoin/blob/371928dbf2d924c7f55db882b7764209cd1e1543/src/script/interpreter.cpp#L463-L464 and https://github.com/jl2012/bitcoin/blob/371928dbf2d924c7f55db882b7764209cd1e1543/src/script/interpreter.cpp#L423-L424
Isn't it better to /add/ a note about these opcodes popping the value instead of adding a DROP to the scripts?
@fivepiece
Isn't it better to /add/ a note about these opcodes popping the value instead of adding a DROP to the scripts?
Either's good to be honest - I was unsure if that branch was meant to the just the BIP, or included nice-to-haves as well.
Pinging @jl2012. Considering this pull has been open since 2018 and the author hasn't responded to the preceding pings and doesn't appear to have any GitHub activity in the past year, I propose to close this pull on June 1st, 2024, if no response in the interim.
Also, the last update to the reference implementation was 8 years ago: https://github.com/jl2012/bitcoin/tree/bip114v2.
Closing this PR, because the BIP was moved to the Rejected status since this PR was opened.
