Nick Fitzgerald

Results 394 comments of Nick Fitzgerald

The dynamic allocation example is measuring a whole lot more than just dynamic allocation: string formatting is rather heavy, and I suspect it is pulling in the panicking infrastructure as...

So you're thinking that we make each `imp` module export a `Backend` trait (or whatever name) that provides the current "duck typed" module interface, but has access to `&self`? ```rust...

I tried this locally, unfortunately commonjs-everywhere doesn't like that amdefine require's "path". Not sure how browserify works around that.

Could be fixed by https://github.com/mozilla/source-map/issues/67

It should be possible, yes! I've been thinking about trying to port criterion over to wasm: https://docs.rs/criterion/0.2.5/criterion/

I haven't looked into `criterion`'s code at all yet, just something in the back of my mind. I've only used it, and been very pleased with the result. Yeah, we...

It looks like our webidl, which is derived from Firefox/Gecko, only has it on the `Window` interface, not on `WorkerGlobalScope`. I wonder if this is supported in workers cross browser?

Rather than returning pointers and lengths manually, you can use this, which should be slightly less error prone: https://docs.rs/js-sys/0.3.9/js_sys/struct.Uint8Array.html#method.view

Thanks for checking with upstream. I suppose we could dynamically keep track of the thread id for the context, and then every operation would get the context and assert that...

Thanks for filing an issue. I have to admit that I'm not super familiar with either windows or cmake. I basically have just done enough to get it building in...