fisker Cheung
fisker Cheung
No rush, just checking, take you time.
This not really bothers me, but lowercase might be a better choice Bootstrap used to use uppercase one until 2 years ago https://github.com/twbs/bootstrap/pull/24217 and reject uppercase few days ago https://github.com/twbs/bootstrap/pull/29363...
@ExE-Boss See https://github.com/prettier/prettier/pull/7391#issuecomment-577099818
Thank you! Fixed in #7391
Actually, I think use a CST is a good idea, it solve many problems, eg comments in `for (;;);`, check the `{}` in `import {} from "foo"`, comments in array...
One reason we are not using tokens https://github.com/prettier/prettier/pull/10492#issuecomment-797146343.
ESLint's [`TokenStore`](https://github.com/eslint/eslint/blob/9b17d6fac6983d2fed4cd005acba17be0a183970/lib/source-code/token-store/index.js#L205) seems a good way to consume tokens.
I'm just saying I like the way how ESLint uses AST, tokens, and comments. We definitely don't want add tokens to Node(we've try to remove attaching comments to Node), but...
https://github.com/prettier/prettier/issues/8122#issue-604552641 https://github.com/prettier/prettier/pull/9830
> there should be first-class support for writing codemods. I don't think any of our team member interest in this.