fisker Cheung comments

Results 1275 comments of


                                            fisker Cheung

Incorrectly calculated line width

If we change the space after `as` to `ifBreak('', ' ')` or `line` fixes it **Prettier 3.6.2** [Playground link](https://prettier.io/playground#N4Igxg9gdgLgprEAuEBtAOlABFg5gJwgFcAHACg2xy3XGgGcZaAaTamkD1qnA48yu16FSZWgDMAlvkYBJeAFsAjEtoBKbkI5YAvCzZC+oyVAAmCGGQA2JuBqzAsk00iwBlAJ4KARhCsA6cQh8MRAAQ3p6SVwoBQt1LABfDQN2Gyg4NyJxKQAPACFiMzD8D00hE3NYWXF8-DgwgGsxHiFBLWojAVSOnFo4U0kYYIAFSTBGuHx9Vt7afxne9lohuAV6RaW+kAWQcq2JSs2trooeg5BQ-a2nMwsz2Zv6CHEYdLhrm7wRbsev0-OX06PweQKWtCugLBOEq91Qz1e72YHFWCloAF0Un9oZJavUmpCQFjoR0EW9bJ8SRw1McqZjKWDHM5XJ4fH5AsFQiVCAB3AC0YAAFmETAlEgybsSqbRdAA+WlggHYr6w2CgqlpClQ6Gndoa9i6laKFgcXbI2gwDwkOAYqX66gyhX6w0gHRuk1IrAAciNa1oXvp2rBgeVNxDGrtQPDUcjW1xdQazX0RIlWjJSKDQnUTq00d6eY6MoiOeo8fxzS9XuRXu9scMIMzMLuar1NzLiYontoAB8OAWtmEbDEyAAmc0gRj4Ey4dSpoQZ0PLEC9ktaQfRKCj8dQIg+KazxtYftCOs4dESxxdWQudxeXwBIIhWgRKIxOKwMWUyMF1WWVAF2gAG5NmjYV8FMBd0T2EAIBIGBJAYZBQG5CAeRGEoEHoZBwisHkwg8LDmBAbx8DCCY4BgNwwjiAAZWxkHEQd6A+GDvAAKzgMAYAAdVIkhsJIepmPwAA3OBoJIsjJkokgyOnZAYHwIgWOYhRJAUpSWLgXJrSnd8YEHAB5XSwmGfARggKJ4OgbCEFMaDtN0yR9MHAAVKYoBKSQ4CwpBGKsZiiKiKBcCsOAAEUiAgeAGKYli2PoXI3GnMLIui8S-LioiAEcovgEZCBIXzwnoPkMgGAZoMUkV0lwABhCAFAUMJsMHKxoOC0K4AAQRgRTJG8Ih8qmOiMligKWMFGAFCsbjBVWehZLATJMKGSQRKGDxsLASJoJE5TZGbSiwCnODurMNxLTC8bApAQTLLgXiwn4lBBJ8qYxOgkxhJgAqwlwZqbpY2SZCmbDTAgMA+UcqxgjBojBJMHjnBgQVkAAdgADiI+pcukOA-oBlrMomoiDO8biUbRpAxxAIhmNcsJvF8-zbrWbwBnMUwaLCEKiH+uAADFgmavr5JQMIhogEBEkSIA) ```sh --parser doc-explorer --print-width 78 ``` **Input:** ```jsx [ group([ "const",...

`prefer-string-raw`: Forbid unnecessary `String.raw`

@som-sm Can you solve the conflicts?

chore: extract AST check from convert.ts to ast-checks.ts

Can we run the AST check from https://github.com/Lonercode/typescript-eslint/blob/65803e4127b9557ec6cf4802df12e588370d9930/packages/typescript-estree/src/convert.ts#L509, and have a big switch-case in the new file to check every ts node?

chore: extract AST check from convert.ts to ast-checks.ts

No need change check-modifiers.ts. In the new file export a function to check ts node, it calls `checkModifier` and do other checks currently lives in convert.ts

chore: extract AST check from convert.ts to ast-checks.ts

`checkTSNode` should only call in `converter`, like the old `checkModofiers` did.

chore: extract AST check from convert.ts to ast-checks.ts

@JoshuaKGoldberg Are you fine with just one check in this PR? Or should all checks done in this one? If we want to copy variable declaration syntax check, better wait...

chore: extract AST check from convert.ts to ast-checks.ts

Looks good to me, thanks! 🙏 Can't approve since I'm not a team member.

Restructure directories

> > ├───prefer-at.js (rule file) > > I think it should be `index.js`. I started using `prefer-at/prefer-at.js` as the entry file at some point, which avoids seeing all files named...

Break before opening brace of interface body

The super class can be a big expression, extra indentation seems not a good idea. Besides ```js if ( looooooooooooooooooooooooooooooooooooooooooooooooongFoo && looooooooooooooooooooooooooooooooooooooooooooooooongBar ) { console.log('baz'); } ``` is much better...

Rule proposal: Enforce `.toArray()` at the end of `Iterator` methods chain

Maybe `prefer-iterator-to-array-at-end` to be more specific? We have the object name in the name like `prefer-{array,string}...`.