fisker Cheung

Results 1275 comments of fisker Cheung

Bug is here. https://github.com/prettier/prettier/blob/7ab72c4f71152c1dad3006b51d18f09f9f87e45b/src/main/front-matter/parse.js#L109 Can you fix from main branch? ``` 'title: "🎂"'.replaceAll(/[^"]/gu, "?") '???????"?"' 'title: "🎂"'.replaceAll(/[^"]/g, "?") '???????"??"' ```

Another suggestion, Maybe the message in the `IMPOSSIBLE` error can add a link to ask the user to report. When I saw this error I was thinking maybe the spec...

I opened #2733, because I think there are maybe people writes `BigInt("-1")`, but I don't think anyone would write `BigInt(!1)`, it should be a mistake.

Need test `-BigInt(-1)` and `-BigInt("-1")`, I think they will fail.

There can also ASI issue since the fixed code inserts `-`. ``` foo //

Ah, this is what you're talking about. Nah, the embed format causes too many problems, that's why we introduced [`--embedded-language-formatting`](https://prettier.io/docs/options#embedded-language-formatting). I prefer not to put it in the docs.

Looks like the only used place in code base https://github.com/babel/babel/blob/4cc3d8888f3e3ac30d38ccfa4557baa7a4a52714/packages/babel-types/src/modifications/removePropertiesDeep.ts#L9 And it can replace with ``` traverseFast(tree, (node) => removeProperties(node, opts)); ```