Erik Österlund

Results 37 comments of Erik Österlund

The nmethods we link together are is_alive. There is also no safepoint. It would be impossible for such nmethods to be flushed without a safepoint. It could racingly flip to...

Also, in DeoptimizationContext::deopt_compiled_methods, the SweeperBlocker completely blocks out the sweeper from running. But as I mentioned, even without that, without safepoint checks, we can never flush these things. It's worth...

> @fisk, is there any chance that in the future we might figure out how to allow nmethods to be flushed without a safepoint? Maybe with handshakes or some other...

Thanks for the review, @stefank

> Hi @fisk, thanks for the amazing cleanup! We've had a bunch of issues with the code sweeper and AsyncGetCallTrace with trying to unwind from dead code blobs (or what...

> Hi Erik, > > > > The change breaks the ARM32 port as the nmethod entry barriers are not implemented there yet. We need a way to work without...

> Erik, > > > > A time ago (not the current code base under review) I noticed that your code sweeper algorithm is more aggressive. > > Capturing data...

> @luhenry @fisk I'm going to stress test it with my [jdk-profiling-tester](https://github.com/parttimenerd/jdk-profiling-tester) on M1 and x86 over night (comparing it with the current master). Thank you!