Erik Österlund

Results 37 comments of Erik Österlund

> @fisk > > I've addressed the feedback. Can you take a look? > > I did not remove the check [here](https://github.com/openjdk/jdk/blob/5dcb7a627e1cfb360719a25722588180e5de9d09/src/hotspot/share/gc/shared/barrierSetNMethod.cpp#L175-L177). Removing this check resulted in time out when...

> > Having said that, perhaps we should file a separate issue to remove that check, since it seems to fix an actual bug, while I guess this was meant...

> Hi @fisk, > > Thank you for the very valuable comment. It has point we have not thought about. > > > I am not fond of "special nmethods"...

> @fisk Thank you for the valuable feedback. Here is a more detailed response to the concerns you brought up Thanks, it's shaping up. > Instead of tracking the nmethod...

Performance results are neutral, as expected. Tier1-5 passed.

Thanks for the reviews @kimbarrett and @xmas92! /integrate