Greg Roach

Results 280 comments of Greg Roach

I've looked at AI coding tools at work, and my experience is that they suck :-) As an experiment, I just asked it to write a test script for a...

LOL. The code looks plausible. However: * Missing import for `Webtrees`. OK, I can fix this. * `new ServerRequest`. No such class. OK, I know what it means, so I...

Now, a human developer would look at this problem and say: > `PublicFiles.php` accesses the filesystem directly, which makes it impossible to test. Instead, it should use the FileSystem abstraction...

There are two options for the height of a chart-box. 1) Fixed height, with long text cropped. 2) Variable height, which expands to contain all text. The design of the...

> Will all the proposed changes be covered by the new system for translations + logic (mentioned in issue #947)? In that case, I'll close this pull request. Keep it...

Support for this is now planned for version 2.1 - #2331

AFAIK, the current silhouette icons came from a public clipart library and don't have SVG originals. More than happy to use SVGs instead of PNGs. At present, we use 3...

I like the idea of using the SVG icons for the silhouette image. Do you think the "solid" icon is better for this? https://fontawesome.com/icons/user?f=classic&s=solid We should use the same image...

There are two changes here: 1. Moving the "configure" icon to the right 2. Adding icons to the title I think the first looks good. I would prefer ` class="d-flex...

As well as death, we have burial and cremation. Would we also want "Death of an ex-husband" for divorced couples? Or should we restrict this event to actual husbands (married,...