webtrees icon indicating copy to clipboard operation
webtrees copied to clipboard

Add block icons

Open ekdahl opened this issue 8 months ago • 5 comments

Suggestion for #5119. If solution is ok, icons can added for other blocks in this PR.

Results in block icon on the left and settings icon on the right: image

ekdahl avatar Mar 16 '25 06:03 ekdahl

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.58%. Comparing base (f2eadec) to head (2de9189).

Files with missing lines Patch % Lines
app/Module/OnThisDayModule.php 0.00% 1 Missing :warning:
app/Module/UserFavoritesModule.php 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5120      +/-   ##
============================================
- Coverage     35.58%   35.58%   -0.01%     
  Complexity    11142    11142              
============================================
  Files          1157     1157              
  Lines         47739    47741       +2     
============================================
  Hits          16988    16988              
- Misses        30751    30753       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 16 '25 06:03 codecov[bot]

There are two changes here:

  1. Moving the "configure" icon to the right
  2. Adding icons to the title

I think the first looks good. I would prefer class="d-flex justify-content-between" to float: end. I think it would look better if the title is long an wraps onto two lines.

I'm not sure about the second change. Maybe if we had icons for more/all of the blocks? It seems odd to have them for just a few blocks.

fisharebest avatar Mar 19 '25 01:03 fisharebest

  1. Ok, will update
  2. Yes, that's why it's only a draft PR, just selected a few blocks to get feedback for the concept before doing more changes.

ekdahl avatar Mar 19 '25 14:03 ekdahl

I think the first looks good. I would prefer class="d-flex justify-content-between"

A question regarding this. Wouldn't that make the title centered instead of directly after the icon at the left side?

ekdahl avatar Mar 19 '25 20:03 ekdahl

Made an attempt to use d-flex instead. Looks like this: image image image image

Not so good for colors unfortunately image

ekdahl avatar Mar 24 '25 19:03 ekdahl