Greg Roach

There is a PR that claims to do this - https://github.com/fisharebest/algorithm/pull/1 This PR is 2 years old and I did not see it before now. :-( I will take a...

Just pushed a change to fix the psalm issues

> Codecov says that some of the new code is untested, most notably the parts using version_compare. Please add functional tests for this change. Running the tests locally says the...

> Ah there is one issue though: since this is a fix, you should target 3.8.x I can create another PR for this branch.

> Please don't, we usually do merges up. Instead, let me retarget your PR, and please rebase your commits on 3.8.x and force push. The PR uses `Connection::getServerVersion()` to select...

I have rewritten my patch to use the `information_schema` instead of server version numbers. This seems more robust, and it should also continue to work if MySQL remove `utf8mb3` in...

> it should also continue to work if MySQL remove utf8mb3 in version 9. Now that MySQL 9.0 is released, we can see that the logic still works, and the...

All the tests are passing. Looks like a missing token in the CI tools.

> * In MySQL 5.7 and below, utf8 is the canonical name and utf8mb3 the alias. > * In MySQL 8.0 and above, utf8mb3 is the canonical name and utf8...