Oliver Stöneberg
Oliver Stöneberg
This also needs tests for the cases the progress was not correctly reported.
> Hm, I'm not sure what you mean, do you have a PR for it? Not yet - #6978 is in preparation of the change I referred to. But I...
FYI when we need to test something related to inputs there is three different cases to consider: - files specified via CLI - files specified via a `.cppcheck` project (basically...
> I'll be focusing on other tickets for a while so I'll pick this up at a later time. Don't end up like me... 🙄
I would prefer to have the code which gets the filesize in `path.cpp`.
> I noticed the percentage reported in `SingleExecutor` for `FileSettings` is based on the number of files instead of the file sizes, is this intentional? No idea - I would...
The value is arbitrary and inaccurate either way - so I would go with the simpler implementation i.e. file count only. It would also match the default ('-j1') behavior.
> I guess we actually have both right now, with `1/3 files checked 42%`. Fair enough.
> > I guess we actually have both right now, with `1/3 files checked 42%`. > > Fair enough. I still think we should drop the file size percentage. Looking...
Ooooooooh. This was never merged - no wonder I couldn't find the changes which I was referring to in https://github.com/danmar/cppcheck/pull/7956#issuecomment-3521535684. BTW the other PR is #7956.