Oliver Stöneberg

Results 1147 comments of Oliver Stöneberg

Still needs more context, ticket and tests. I also have the feeling that I rejected this change at some point before.

The difference in the output of `test_invalid_addon_py_verbose` is tracked in https://trac.cppcheck.net/ticket/13389.

~~`test/cli/helloworld_test.py::test_sarif` - https://trac.cppcheck.net/ticket/13393 (Windows only)~~ ~~`test/cli/helloworld_test.py::test_xml_checkers_report` - https://trac.cppcheck.net/ticket/13388~~ / https://trac.cppcheck.net/ticket/13390 (not fixed but test passes) `test/cli/inline-suppress_test.py::test_unmatched_cfg` - https://trac.cppcheck.net/ticket/13087 `test/cli/inline-suppress_test.py::test_unmatched_suppression` `test/cli/inline-suppress_test.py::test_unmatched_suppression_path_with_extra_stuff` `test/cli/inline-suppress_test.py::test_unused_function_disabled_unmatched` - https://trac.cppcheck.net/ticket/13087 ~~`test/cli/inline-suppress_test.py::test_xml` - https://trac.cppcheck.net/ticket/13388~~ ~~`test/cli/inline-suppress_test.py::test_unused_function_unmatched` - https://trac.cppcheck.net/ticket/13087~~ `test/cli/metrics_test.py::test_dummy_metrics_stdout`...

We should have opt-in/opt-out CLI options so this behavior can be overridden. And it should probably be disabled by default (I feel like there was already a discussion where I...

> We should also somehow inform the user when a file is omitted because it is a duplicate (within `--check-config`?). This is something I need to do in a different...

Something for a future improvement. Some of the settings could be sanitized so they are not different if the order is different. Please do not do this for the defines...

> What's a scenario where you'd want it to be disabled? Where it omits files from the analysis it should not (i.e. bugs). The existing handling of duplicates in other...

> So a flag to disable _all_ de-duplication? Just for this added logic as it many parts which make up the hash. The existing de-duplication is based on the (real)...

This introduced a performance regression (hang): https://trac.cppcheck.net/ticket/13995.