Jonathan Behrens

Results 621 comments of Jonathan Behrens

I think we should start by adding a benchmark of the user-facing functionality that we want to optimize. In this case, I believe it would either be measuring either `ImageBuffer::convert`...

Looks like there was also an abandoned PR: #1356. For reference (since I didn't remember off hand what it did), this is the implementation of `resize_dimensions`... https://github.com/image-rs/image/blob/2125965fdc23ea0544fd585f6e934cc7762c1f51/src/math/utils.rs#L5-L40

Could you check what version of the `png` crate you're using? There was a bug in ICC encoding in the 0.17.15 version that was fixed in the next release

Including all the format selection logic into `image` might be a good option. We'd need some inclusion criteria, but something like only accepting formats supported by ImageMagick would probably be...

Created #2372 to try out a global hooks design. I'm not quite sure how something like `flexible-io` could factor into the design in a backwards compatible way, given that user...

@HeroicKatora how would you feel about moving forward with this PR and then spinning out a single `image-extras` crate that uses hooks to support additional non-default format bindings, like the...

My top-level goal is finding a way to spend less time thinking about, reviewing, and supporting obscure formats. IMO most of the effort around obscure formats is preparing/preventing them from...

I created https://github.com/image-rs/image-extras to test out the usage of this API. In my view, there isn't much point in having hooks if they're going going to be for overriding the...

Haven't had much time to work on decoding hooks, but wanted to at least update where things stand... While trying to use this API from `image-extras` I discovered that the...

Ok, I've switched over the hooks to operate on file extensions rather than `ImageFormat`. There's now format detection hooks which take magic bytes and an optional mask, and map to...