Jonathan Behrens
Jonathan Behrens
Shorter repro: ```rust let img = Rgba32FImage::from_raw(1, 1, vec![1.0 / 0.]).expect("create nan image"); DynamicImage::ImageRgba32F(img).to_rgba8(); ```
This is related to https://github.com/image-rs/image/issues/1952. The `DynamicImage` enum implements `GenericImage` even though it really shouldn't
Shouldn't there be more logic to actually handle reading/writing these types?
The hard part is still [this concern](https://github.com/image-rs/image-tiff/issues/204#issuecomment-1566616975): > This makes sense to fix, though the annoying part is figuring out whether anywhere else in the code is relying on the...
Cargo semver-checks doesn't capture behavior changes. If there's downstream code that assumes (perhaps via `if let`) that it'll get a `Value::Unsigned()` for something and we switch the decoder to produce...
Mesa also has a [bit-exact float64 polyfill](https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/compiler/glsl/float64.glsl) for GLSL.
CI seems to be failing because this exposes the tiff crate's `Compressor` type
I've been taking a hiatus from most PR review and issue triage because I got burned out following the 0.25 release. Another reviewer might have a chance to review this...
@maxall41 This PR adds RGB and RGBA 32-bit floating point support, but notably doesn't add support for single-channel floating point images like the one you attached. Though it would probably...
Not a maintainer, but FYI this is an API breaking change because any downstream code relying on the now cfg'd out methods will no longer compile. If rayon was left...