Finn Bear

Results 246 comments of Finn Bear

The fact that it panics as opposed to returning an error or `false` is definitely a bug, and I'll submit a PR to fix it shortly :) For now, a...

Something that we discussed in Discord was the possibility of an imperative client API, almost like an ORM (as opposed to declarative SQL API). I personally think this is a...

@rustbot label +T-libs-api -T-libs

@rustbot label +S-waiting-on-review -S-waiting-on-author

In an attempt to undo the merge commit, I messed up git beyond my ability to repair it, so this PR is superseded by #103280

> @finnbear mind taking a look? Sure; I recommend using a `BTreeSet` to avoid `derive(Hash)`'s as per https://github.com/surrealdb/surrealdb/pull/1218#discussion_r979293193

> > > @finnbear mind taking a look? > > > > Sure; I recommend using a `BTreeSet` to avoid `derive(Hash)`'s as per [#1218 (comment)](https://github.com/surrealdb/surrealdb/pull/1218#discussion_r979293193) > > As this PR...

> I think you meant `NaN != NaN`. If equality isn't reflexive, we're not allowed to `impl {Eq, Ord} for Number` and therefore we are also not allowed to `impl...

> Or, to be consistent with the other special math case of dividing by 0 we could use `Value::None` as I remember reading in some issue @tobiemh wanted null to...

> How about adding a restriction to floats in SurrealDB to say they can't be `NaN` [like what this crate does](https://docs.rs/ordered-float/latest/ordered_float/struct.NotNan.html)? This way we can sidestep issues with NaN. Yes,...