Piotr Findeisen

Results 644 comments of Piotr Findeisen

cc @charlesjmorgan @findinpath

Another example spotted 2 weeks ago by @losipiuk ``` Error: COMPILATION ERROR : Error: /home/runner/work/trino/trino/core/trino-main/src/test/java/io/trino/sql/planner/TestLocalDynamicFiltersCollector.java:[272,81] incompatible types: inference variable T has incompatible bounds equality constraints: io.trino.spi.predicate.Domain,K lower bounds: io.trino.spi.connector.ColumnHandle Error:...

https://github.com/trinodb/trino/actions/runs/9043779034/job/24851801655?pr=21931 ``` OS name: "linux", version: "6.5.0-1018-azure", arch: "amd64", family: "unix" Error: COMPILATION ERROR : Error: /home/runner/work/trino/trino/lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/filter/TestUtcConstraintExtractor.java:[185,57] incompatible types: inference variable T has incompatible bounds equality constraints: io.trino.spi.predicate.Domain,K lower bounds:...

> > By using the now deprecated syntax, we are able to do insertions into a versioned Iceberg table. > > That should probably be rejected, as it’s semantically meaningless...

can this be anyhow related to https://github.com/trinodb/trino/pull/19479?

> @findepi and @electrum can you chime in here and figure out whats next? since there is a red mark, a slight preference would be for David to follow-up

> These are handled indirectly by the `ReportUnannotatedMethods` check In one direction ("checker ensuring that a TestNG test does not extend from JUnit-annotated test class"), yes.

The checker won't run for a child class.

Same for `TestIcebergConnectorSmokeTest` & `TestIcebergJdbcCatalogConnectorSmokeTest` https://github.com/trinodb/trino/actions/runs/9032124170/job/24820406673?pr=21908 ``` Error: Errors: Error: io.trino.plugin.iceberg.TestIcebergConnectorSmokeTest.testDeleteRowsConcurrently [INFO] Run 1: PASS [INFO] Run 2: PASS Error: Run 3: TestIcebergConnectorSmokeTest>BaseIcebergConnectorSmokeTest.testDeleteRowsConcurrently:165->BaseIcebergConnectorSmokeTest.lambda$testDeleteRowsConcurrently$2:161 » IllegalState Task 0 did not complete...