trino icon indicating copy to clipboard operation
trino copied to clipboard
verified publisher icon trinodb

Do not retry iceberg operations on unrecoverable exceptions

Open oskar-szwajkowski opened this issue 2 years ago • 15 comments

Description

As in title

Additional context and related issues

Release notes

(X ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

oskar-szwajkowski avatar Oct 07 '23 21:10 oskar-szwajkowski

@electrum could you take a look again?

oskar-szwajkowski avatar Oct 12 '23 11:10 oskar-szwajkowski

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Jan 10 '24 17:01 github-actions[bot]

👋 @oskar-szwajkowski could you ensure any rebase necessary is done and CI passes. @electrum could you have a look again.

mosabua avatar Jan 11 '24 20:01 mosabua

👋 @oskar-szwajkowski could you ensure any rebase necessary is done and CI passes.

Rebased original branch, but there were no conflicts.

oskar-szwajkowski avatar Jan 18 '24 14:01 oskar-szwajkowski

@findepi and @electrum can you chime in here and figure out whats next?

mosabua avatar Jan 18 '24 20:01 mosabua

@findepi and @electrum can you chime in here and figure out whats next?

since there is a red mark, a slight preference would be for David to follow-up

findepi avatar Jan 31 '24 15:01 findepi

My comment about making this applicable to the new file systems has not been addressed. This feature is only useful for the deprecated S3 file system, so I'd rather not add it just for that.

electrum avatar Jan 31 '24 15:01 electrum

@oskar-szwajkowski could you address the request from @electrum please?

mosabua avatar Jan 31 '24 17:01 mosabua

@oskar-szwajkowski could you address the request from @electrum please?

@electrum I added handling of retryable / non retryable exceptions in new s3 based file system

oskar-szwajkowski avatar Feb 01 '24 13:02 oskar-szwajkowski

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Feb 22 '24 17:02 github-actions[bot]

@electrum I think this is ready for another look from you.

mosabua avatar Feb 22 '24 17:02 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar Mar 21 '24 17:03 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Apr 11 '24 17:04 github-actions[bot]

@oskar-szwajkowski @electrum @findepi @amogh-jahagirdar @bitsondatadev .. can you help out here to get this towards merge?

mosabua avatar Apr 11 '24 20:04 mosabua

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

github-actions[bot] avatar May 10 '24 17:05 github-actions[bot]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions[bot] avatar Jun 03 '24 17:06 github-actions[bot]

Reopening to allow @electrum to review and chime in.

mosabua avatar Jun 03 '24 18:06 mosabua

This PR is superseded by https://github.com/trinodb/trino/pull/22814

oskar-szwajkowski avatar Jul 25 '24 13:07 oskar-szwajkowski