Filip Hracek comments

Results 129 comments of


                                            Filip Hracek

after installing english_words,it is not working

Can you please try to open pubspec.yaml and then click `Packages get` at the top?

Fix : tab reloading when changed

Thanks for the contribution! I'd love to merge this, but could you please filter out the extra changes? I see some additional print statements and changes to things like `local.properties`,...

Fix : tab reloading when changed

Sorry for being difficult, but I still see whitespace changes in 4 files: https://github.com/filiph/hn_app/pull/9/files.

[Accessibility] Modal dialogs should truly be modal

Thanks! Could you please have a look at https://dart-lang.github.io/angular_components_example/#/material_dialog (scroll down to open the examples) and check whether this implementation of modal dialogs is good enough? I was going to...

Slight UX/UI idea/suggestion

Good suggestions, thanks! Leaving this open as I do want to do this — but not on my high priority list.

FileSystemException: writeFrom failed, path = '' (OS Error: Broken pipe, errno = 32)

I'm sorry, I cannot reproduce this. Could you please share a bit more info about your setup (operating system, the kind of server you're trying to linkcheck, etc.)?

Proposal to integrate the `robots_txt` package.

Thanks for the suggestion, @vxern! I'm afraid I don't have the time to implement this. Are you suggesting you'd implement this as well? Also, cc @parlough for his opinion.

Retries for potentially transient errors

For what it's worth, I really like this idea. I don't think I'll have the time to implement it myself anytime soon, though..

[Suggestion] Output to text file

I use the usual unix piping for this: ```sh linkcheck :8000 > output.txt ``` Does this work for you?

Save results as json

That's not currently possible, unfortunately. What would be the exact use case? (I'm trying to gauge how the JSON should look like, if it should be streamed rather than dumped,...