Filip Hracek

Results 129 comments of Filip Hracek

Hi @push-over and @conghaonet, Sorry for the complete silence on this issue (and the repo in general). I've been unsure about the future of the `provide` package but now I've...

Does this include closure variable shadowing? I just found a nasty bug that looks something like this (identifier names have been changed to protect their identities): ```dart void prepareDeliciousMeal(Fridge f)...

Another low hanging fruit would be something like this: ``` dart void init() { .... if (gStreamingPauseBackground == null && gUseStreamingPause) { ... gStreamingPauseBackground.initRHI(); } } ``` This can easily...

And another one: ``` dart if (someValue.isEmpty) { ... } ... if (someValue == null) { ... } ``` Basically, whenever there is any check for `null` (even a null-aware...

Also applies inside one if statement: ``` dart if (someObject.name.startsWith("Mr. ") || someObject == null || someObject.age >= 18) { ... } ``` Sorry for the comment spam. These bugs...

I like the idea. Depends on the metadata requirements, though. You means something like the following? ```dart // A file in flutter/flutter /// Blah blah blah widget. /// /// [[catalog_widget]]...

Just to add: a missing `key.properties` file is bound to happen at times, since it's a secret file with passwords, and it's `.gitignore`'d by default. So it's easy to get...

Just confirming I'm on this. Thanks for your patience!