Fabian Holler comments

Results 78 comments of


                                            Fabian Holler

inconsistent port attribute in structs tr_tcp_config and tr_ssh_config

Like @nbars mentioned, the TCP socket supports to pass a service name (/etc/services) or a port number as char *. It's then resolved from getaddrinfo to a numeric value. The...

Handle multiple RTR connections in same thread

Yes, using select() could also be sufficient. I would vote for only one thread that handles all connections including multiple manager group, it doesn't provide a benefit to have a...

Create a general test framework for RPKI-RTR client implementations

Cool! :-) That's basically what I had in mind. I would prefer to make a seperate project out of it and use a higher-level language for it like Python, maybe...

Improve configuration struct API

Let's resume the discussion about a new API on the base of @nbars suggestion in #86. - Why do we have rtr_mgr_groups? They seem to only increase complexity for the...

Improve configuration struct API

#38 is related

Improve configuration struct API

@waehlisch Yes, would be great to discuss the disagreements. I'm not also not sure about some things. :-)

nolintlint: reports false positive warnings about used nolint directive

The issue happend again with golangci-lint 1.50.0.

postgres TEXT[] type mapped to []sql.NullString, insert fails

@kenshaw thanks a lot :-)

postgres TEXT[] type mapped to []sql.NullString, insert fails

Same problem for the`[]int16` psql database, it also get's the wrong type assigned in the generated XO code

postgres TEXT[] type mapped to []sql.NullString, insert fails

@kenshaw Yes, the problem might exist for all PSQL array types that can be NULL. If I have a field of type `integer[] NULL` in a psql table, xo is...