Fabian Holler comments

Results 79 comments of


                                            Fabian Holler

return errors in sendOpen function

> I noticed that function `sendOpen` always return nothing, but signature of function says that it should return error It currently returns the named return values, which includes `err`. Your...

Redirect go to new location.

@tedsuo could this be merged?

Add ctx in SpanDecorator option

@rnburn could this be merged?

nil pointer dereference in getConn(), span is nil

Nevermind, I did not set the http transport for the client: :-/ ``` http.Client{Transport: &nethttp.Transport{}} ```

nil pointer dereference in getConn(), span is nil

I think this is nonetheless an issue. If the Transport of the http client must be set to prevent the nil pointer exception, it means that we can not inject...

Post jenkins build output (console output) to slack

> Why can't you just use the ${BUILD_LOG} jenkins macro in the custom message field? @dsteinmo $BUILD_LOG is not a variable set by jenkins, it's only available in the context...

Please add support to have multiple Slack Notifications

@jensolsson If you have a Jenkins Pipeline job you can run in the `post {}` section depending on the job status, e.g.: ```groovy { post { success { slackSend(channel: "#qa",...

output command :map poorly readable

This is fixed for my in the master branch (9051480ad9129ff4ab4fffb38b44779b9081626f). I did not investigate which commit exactly fixed it.

Create "db export" and "db import" commands

Do you only need read-access to the data from the baur database in in CI? Or do you also create new records for the baur database in CI or by...

Create "db export" and "db import" commands

Would it help if there would be a cleanup command to remove database records older then X?