Fabian Holler

Results 78 comments of Fabian Holler

> I want to implement this as its very handy to us. That would be great :-) > Do you have any preferred way for this to be implemented? >...

sounds great :+1:, some comments: > Example flow: > > 1. Generate build output temp file, available via `{{ .buildResultsJsonPath }}` or `BUILD_RESULTS_PATH` env variable Should be sufficient to only...

I'm not sure if it's worth to implement the command. The information can be shown via `baur diff inputs`, it could almost be an alias for `baur diff inputs ^`...

It's missing in my issue description, the main motivation was that when baur is updated to a newer version there are often git-branches around that still needs to be build...

Is this issue fixed? The PR was merged a while ago.

I ran into a similar issue with the pq driver. According to https://github.com/golang/go/blob/f865b5fefeafaf76ce6ff99e44d41c52cb6b884b/src/database/sql/driver/driver.go#L275: > // The sql package checks for value checkers in the following order, // stopping at the...

@nvx thanks, do you maybe know if https://github.com/luna-duclos/instrumentedsql/issues/41#issuecomment-883247352 is an issue?

@nvx Yes, the particular issue that I had related to lib/pq + value conversion is fixed in master. It looks to me that the current implementation from your PR (https://github.com/luna-duclos/instrumentedsql/issues/41)...

@dadrus thanks for the info. I discovered https://github.com/ngrok/sqlmw in the meantime and think it is a great approach. It allows to abstract driver wrapping logic from the added functionality like...

related issue: https://github.com/grpc-ecosystem/grpc-opentracing/pull/43