Francesco Romani
Francesco Romani
@jaypipes eventually I come to like this approach. We may need a couple more iteration to sort out the details of the API (naming, printing) but overall I'm happy to...
depends on https://github.com/jaypipes/ghw/pull/351
Now that we agreed on the direction, I need to add tests. Will do ASAP.
we agreed to move forward with #315
> I'm glad to see refactoring with the native Go ethtool library removed many package dependencies and even simplified the code! > > If we decide to go this route,...
@jaypipes just wondering: would a minimal `ethtool` package (perhaps unexported, like in `internal/`?) tailored for the needs of the project be a welcome addition to `ghw`? I'd like to move...
> > @jaypipes just wondering: would a minimal `ethtool` package (perhaps unexported, like in `internal/`?) tailored for the needs of the project be a welcome addition to `ghw`? I'd like...
thanks for this contribution @sspring ! could you please add a unit test to ensure this code doesn't regress? None of the active main contributors is a windows user, so...
LGTM from sig-node perspective. Very straightforward.