Francesco Romani

Results 485 comments of Francesco Romani

> @fromanirh, the more I look at this patch, the more I think these changes belong in the `pkg/pci` package and not as a new `pkg/sriov` package. The fact is,...

at long last, the alternate implementation is available: https://github.com/jaypipes/ghw/pull/315

I tend to agree the code should not set the drive type depending only on the value of `rotational`

That's a good point indeed. These are abstractions provided by the linux kernel which happen to be presented using the same interface as the real devices. From this perspective it...

I wonder if a simpler output like the one in the tree utility (https://linux.die.net/man/1/tree) can be a good intermediate step - or even a valid alternative

Hi there, I can contribute here, depending on the decision we take in https://github.com/jaypipes/ghw/issues/66 (and also https://github.com/jaypipes/ghw/issues/201 :) )

I have access to boxes with low and high end SRIOV cards and I can provide snapshots (albeit most likely for low-end cards only) to enable others.

first draft, RFC for API: https://github.com/jaypipes/ghw/pull/230

At glance, it seems you used the code correctly, but we have a bug in the `block` pkg if there is a filesystem directly on the block device, and not...

Sure, I need to work on a reproducer myself and then we can create a fix. Feel free to contribute fixes if you have time, I'd be happy to review.