Francesco Romani
Francesco Romani
this PR is reviewable, but tests are still WIP. The alternate API is pretty much stable though.
> @fromanirh did you want to rebase this and have it reviewed? Sure, I'll rebase shortly! other than that this is not very urgent. Up to us if we like...
note that most of the tests are missing - deferred until we settle about the direction. Should not be merged without tests, though.
> @fromanirh apologies for the delayed review. > > I think I would prefer to have the SRIOV-specific attributes added to the `pkg/pci.Device` struct itself instead of having an "extended"...
yes, that's actually a good point I should have considered :\
Thanks for this PR! I'm generally in favour of moving from `/proc/cpuinfo` to `sysfs` to learn about the CPU data. Let's check this change is covered by the existing tests,...
/cc @jaypipes because cpuinfo -> sysfs move and support for extra arches
> > we would need some aarch64 and riscv64 machines to run at least some CI on; unfortunately, code outside CI bitrots pretty fast. I'm not aware of option (not...
adding arm support would be very nice indeed. Unfortunately we still need to sort out the CI and the supportability aspects, because we very much want to avoid the feature...
@Itxaka that's a very good point, thanks for raising. I'll revisit again shortly. One of the problems I have around this area is I'm not really sure the current behaviour...