Felix Frank

In practice, though, requiring the user to specify `--someflag ""` is poor UX, anyway. It would be nice to be able to add flags with polymorphic type, so that its...

Oh, I only just realized that his _is_ in fact part of stdlib. In light of this, I guess I'd vote to close...work with what we have. If you really...

I believe that this is addressed by #434.

FWIW, the `nginx::nginx_upstreams` should work. `nginx::nginx_vhosts` is probably ignored because the parameter is actually called `$nginx_servers`, so you'll need the Hiera key `nginx::nginx_servers`. For debugging: 1. Put a `notify {...

😭 Well apart from that mixup, I do at least stand by my recommendations, minus the re-rename of the parameter 😅

Thanks for keeping score.

Perhaps we should switch the whole module to this, er, "[pattern](https://github.com/puppetlabs/puppetlabs-apache/blob/cf2ff7eaeaefa693f3c9d235e3ad2256734fbb6d/manifests/vhost.pp#L171-L173)".

I will eventually go ahead and change the testing approach. This is a low priority, however.

@apeeters are you working on a patch, or are you waiting for peer feedback? @wyardley why is this labelled as "skip changelog"? I feel that a change like this should...

Uh, I think I'm rather confused about the semantics of that label. I thought it would lead to a possible fix being omitted from the change log? If that's not...