Wangchong Zhou comments

Results 195 comments of


                                            Wangchong Zhou

BoringSSL not working HTTP3

Hi @Hackintoshcorp boringssl doesn't export symbols by default when statically linked, but our FFI library requires export symbols to lookup functions. so you can only use boringssl by dynamically linked....

【已知问题】进一步优化电量消耗

用开发版的usb供电的话，串口芯片和稳压器会消耗很多，datasheet里理想情况下ESP32的deep sleep电流应该在1ma以下。另外唤醒联网的时候会有一个突发的几百毫安的电流，电池会有明显压降，然后供电不足重启，导致电池还有电但看起来没电了。

Fix check for private key existence before eddsa sign functions

I will add test tommorow, thanks for reviewing!

Fix check for private key existence before eddsa sign functions

I have addressed the comments and sent CLA to legal. When I was running test locally, the pkey creation always fails with ``` routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:341:Global default library context, Algorithm (ED25519 :...

Fix check for private key existence before eddsa sign functions

Thanks everyone for reviewing! As this issue also exists in 1.1.1 branch, should I open another PR targeting that branch?

ED25519_sign and ED448_sign missing check for private_key leading to segfault

@slontis Yes Ed448 sign also has the same issue, I fixed them together in PR 19525. I agree we can also additionally check for NULL in `EVP_DigestUpdate` for safety. On...

perf(*) use ngx.req.set_header to set upstream_headers

this need some rethink, closing this and record it with CT-22

fix(*) remove coroutine in access phase

Since now we have passed 3.0, we can only postpone this to 4.0. @hbagdi Do we want to keep this open or other ways to track it?

Add Kong to integrated projects

Friendly ping @tdelmas, is this client options PR still being considered?

ZeroSSL integration failing to create account

Closing as inactivity, please reopen if needed : )