Wangchong Zhou comments

Results 195 comments of


                                            Wangchong Zhou

chore(ci): add direnv virtual env integration

Could you explain a bit more on what are the differences of using direnv compared to `source` directly? (Would it work if you directly `source bazel-bin/build/kong-dev-venv/lib/venv-commons` which only contains environment...

chore(ci): add direnv virtual env integration

I see, so it's like automatically handling activate and deactive the "virtual env". As right now in this PR we are just exporting env variables, will it work for just...

Option to delete none whitelisted domains in certificate update

@joergmoldenhauer That's a good idea. PRs are welcome! I will pick it up if no one is working on it : )

fix(llm): fix nil error when identity_interface error

Thank you! Nice catch!

fix file renaming after task completion

没看懂，改了啥 🤔

fix file renaming after task completion

下载过程中所有图片都会用`id.jpg`，是因为save_tasks=False的时候也可以续传。然后只能用网页底下写的文件名当成原始文件名，因为有些url里没有文件名

fix file renaming after task completion

原始文件名是从这里取出来的 https://github.com/fffonion/xeHentai/blob/master/xeHentai/filters.py#L194 如果有问题应该是这里的问题，可能正则需要改一下

fix file renaming after task completion

> 目前好像没这种情况了我记得和本子的热门程度有关，有些是走pcdn的，有些不是，会影响url的pattern > 我观察是在完成任务后的def rename_fname才出的问题，所以才这么改可以看一下renamed_map里面的内容正不正确，因为你这个PR删掉的内容都是需要的（可以blame看当时加上的原因），所以我有点困惑到底什么地方有bug

fix file renaming after task completion

等我有空的时候研究一下！

Exposing LD make environment variable breaks cross compilation

To compare the difference, following is the Configure.log when using rules_foreign_cc 0.9.0: [olda.log](https://github.com/user-attachments/files/16949220/olda.log)