Wangchong Zhou comments

Results 195 comments of


                                            Wangchong Zhou

Prometheus plugin causes much longer serving duration for concurrent HTTP requests

We can add some `yield`s to the scrape funtion, if you have lots of entities collected, the worker process won't be able to handle other requests until the full `collect`...

all the routes and upstreams will be put after only one k8s services/endpoints are rolling update

cc @Kong/team-k8s

feat(acme): add host on certificate update log

maybe we should also add `host` for error log at Line 156 for future us 😄

fix(*) drop luasocket in CLI

@Tieske How do you feel about https://github.com/Kong/kong/pull/8993/commits/a6a1c72aaf33f461b7e5f509737e637f17584f52 🤔 ? I haven't really tested it, but it shows proof of concept.

@Tieske it seems the only two parts that does network connection is: 1) cluster_events update its initial time (https://github.com/Kong/kong/pull/8993/files#diff-bf75cd7b30a4bf3453f56734db348cbed164bf32a6be22107e950c6f64fcd079L129) updated to the fallback method to use ngx.time() (let me know...

Kong Kubernetes Ingress does not allow additional proxy listen ports

Hi @kkmoslehpour as this is a KIC specifc issue, please open a discussion at https://github.com/Kong/kubernetes-ingress-controller/discussions. I'm closing the issue here, thanks.

perf(*) use ngx.req.set_header to set upstream_headers

Note from dicussion with @bungle : removing of those variables may break for use cases like https://github.com/Kong/kong/issues/5559. Do we consider that a break considering using those variables are not officially...

perf(*) use ngx.req.set_header to set upstream_headers

@dndx yes it will since log_serialzer is in log phase. how do you think for this caveats? maybe we just hide all x-forwarded- headers in log_serializer?

fix(db) use a checksum to limit unique key length

Using message digest for non-cryptographic purposes is a vague area of fips, but we should use algorithms like sha256 just to be safe.

fix(*) remove coroutine in access phase

Test is green now, it does seem we are "unconsicously" relying on this behaviour. I did a cleanup and now it's correctly exited.