kong icon indicating copy to clipboard operation
kong copied to clipboard

fix(llm): fix nil error when identity_interface error

Open t-yuki opened this issue 1 year ago • 3 comments

Summary

Misconfigured ai-proxy causes unexpected nil error, instead of usual error, due to calling missing function. It is occurred when bedrock model provider is configured without aws_region configuration. In this PR, it's fixed by calling proper function.

Checklist

  • [ ] The Pull Request has tests
    • no test exists for bedrock configuration
  • [ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #13666

t-yuki avatar Sep 14 '24 10:09 t-yuki

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 14 '24 10:09 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 14 '24 10:09 CLAassistant

Thank you! Nice catch!

fffonion avatar Sep 19 '24 05:09 fffonion