D. Ferruzzi
D. Ferruzzi
hmmmmmmm. yeah, I think maybe you are right. As of 3.8, dicts are guaranteed to retain the order they were inserted and we require 3.8+ for Airflow so.... yeah, that...
@potiuk - I'm sorry, I got distracted by a shiny new thing and completely forgot about this after you tagged me @jedcunningham - Thanks for fixing it.
> @ferruzzi do I have any update on this part? How would that work? A gauge is an arbitrary reading, you just tell it what the new/current value is. Unless...
This would break the dashboard of any user currently monitoring that metric and their timers will suddenly show 1000x longer durations, right?
I never said don't fix it. It's just a matter of if we call it a bugfix and fix it now, creating a breaking change and sending users scrambling to...
KILOSECONDS? Why the heck used KILOSECONDS for anything? It looks like consensus is that we don't have to deal with deprecation, so that's great.
@Bowrna @HTRafal @tanvn - Does this proposed change look like it will address your comments? If you all confirm, I'll approve and we can get it merged. The code looks...
Cool. @htpawel - If you can add that quick unit test, I'll approve and merge this.
> What test did you have in mind? I can't think of any to accomplish this If you are trying to make sure the metric is emitted in seconds and...
> Developers just must know that Statsd expects milliseconds or delta object only, that's convention. That's horrible. So we don't have any way of knowing, catching, or preventing this from...