airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Compatiblity wiht libxmlsec 1.3.14 for Amazon Provider

Open potiuk opened this issue 1 year ago • 1 comments

Body

The xmlsec used by Amazon provider for authentication has compatiblity issue with libxmlsec 1.2.* that is used by default in debian bookworm.

We should investigate if/howe we can upgrade our images to support it, in the meantime we limitt python bindings to < 1.3.13.

Committer

  • [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.

potiuk avatar Apr 18 '24 08:04 potiuk

cc: @ferruzzi @vincbeck might be worth looking at

potiuk avatar Apr 19 '24 12:04 potiuk

@potiuk - I'm sorry, I got distracted by a shiny new thing and completely forgot about this after you tagged me

@jedcunningham - Thanks for fixing it.

ferruzzi avatar May 09 '24 17:05 ferruzzi

Fixed by #39103

potiuk avatar May 10 '24 04:05 potiuk

Just for posterity: I did nothing to fix it (I just removed the pin), but 1.3.14 no longer exhibits a problem.

jedcunningham avatar May 10 '24 14:05 jedcunningham

@jedcunningham that's because xmlsec project uploaded binary wheels for 1.3.14 (see recent comments in https://github.com/xmlsec/python-xmlsec/issues/316) so perhaps the pin inside airflow should be removed now, since they are expected to do that going forward.

We are actually running into problems with 1.3.13 that .14 is meant to address, so airflow's pin is preventing that upgrade.

vitaliyf avatar May 12 '24 16:05 vitaliyf

@jedcunningham that's because xmlsec project uploaded binary wheels for 1.3.14 (see recent comments in xmlsec/python-xmlsec#316) so perhaps the pin inside airflow should be removed now, since they are expected to do that going forward.

We are actually running into problems with 1.3.13 that .14 is meant to address, so airflow's pin is preventing that upgrade.

Yes. This is what we did.

potiuk avatar May 12 '24 16:05 potiuk

@potiuk ah yes, I think I got confused while looking through code in your fork instead of apache/airflow 🤦. Thank you!

For posterity: pin removed in https://github.com/apache/airflow/pull/39534 and should be released in apache-airflow-providers-amazon version > 8.21.0

vitaliyf avatar May 12 '24 16:05 vitaliyf